chore: minify html and css for releases #2262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For releases, the HTML and CSS assets will be minified before being inlined into the built JS
googlebot
added
the
cla: yes
jelbourn
reviewed
Dec 18, 2016
| @@ -8,6 +8,9 @@ import {writeFileSync} from 'fs'; | |||
| // No typings for these. | |||
| const inlineResources = require('../../../scripts/release/inline-resources'); | |||
| const rollup = require('rollup').rollup; | |||
| const gulpMinifyCSS = require('gulp-clean-css'); | |||
| const gulpMinifyHTML = require('gulp-htmlmin'); | |||
There was a problem hiding this comment.
gulpMinifyCss and gulpMinifyHtml
| /** Minifies the HTML and CSS assets in the distribution folder. */ | ||
| task(':build:components:assets:minify', () => { | ||
| return src('**/*.+(html|css)', { cwd: DIST_COMPONENTS_ROOT}) | ||
| .pipe(gulpIf(/.css$/, gulpMinifyCSS(), gulpMinifyHTML({collapseWhitespace: true}))) |
There was a problem hiding this comment.
Also caseSensitive: true, removeComments: true?
|
@jelbourn Made the requested changes. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jelbourn Basically as mentioned on Slack, I had to decouple the
:rolluptask from theinlining, so we can control the inlining of the resources.Closes #2066