Skip to content

refactor(material/theming): normalize config in all typography mixins for mdc components #21935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2021
Merged

refactor(material/theming): normalize config in all typography mixins for mdc components #21935

merged 4 commits into from
Apr 12, 2021

Conversation

mmalerba
Copy link
Contributor

This is split off of #21778 which covers non-MDC conmponents as well

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 17, 2021
crisbeto
crisbeto approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the CI is failing.

@mmalerba mmalerba force-pushed the typog-norm-mdc branch 3 times, most recently from f143f1c to 2b7ddd0 Compare February 18, 2021 21:12
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Feb 18, 2021
andrewseguin
andrewseguin approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - should this change be made in internal Google Material components as well?

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2021
@mmalerba
Copy link
Contributor Author

mmalerba commented Mar 5, 2021

Yeah, I need to look into the screenshot diffs for this PR because I wasn't really expecting any. But once it's in we should do the same for Google Material components

@annieyw
Copy link
Contributor

annieyw commented Apr 1, 2021

@mmalerba needs rebase

@mmalerba mmalerba added the P2 The issue is important to a large percentage of users, with a workaround label Apr 8, 2021
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Apr 12, 2021
@mmalerba mmalerba merged commit 03be924 into angular:master Apr 12, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @annieyw @crisbeto @andrewseguin