fix(material/datepicker): a couple of accessibility issues in touch UI mode #21228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
mmalerba
added
merge: fix commit message
|
commit message should say datepicker instead of dialog |
crisbeto
changed the title
…I mode Resolves the following accessibility issues when the datepicker is in touch UI mode: * Focus was going directly to the close button, because that's the first element that the dialog's focus trap was running into. I've disabled the automatic focus redirection since the calendar has its own. * The calendar close button for screen readers was off-screen, because the dialog container has `position: static` and `overflow: auto`. Apart from the two issues above, I've also made it so the screen reader button's theme color matches the one of the calendar. This is mostly so the button doesn't look out of place if the calendar has a different theme and the user tabs into it.
crisbeto
force-pushed
the
datepicker-close-button-a11y
branch
from
92fbb5c to
ccbc7f9
Compare
crisbeto
removed
the
merge: fix commit message
wagnermaciel
added
the
target: patch
annieyw
pushed a commit
that referenced
this pull request
Jan 6, 2021
…I mode (#21228) Resolves the following accessibility issues when the datepicker is in touch UI mode: * Focus was going directly to the close button, because that's the first element that the dialog's focus trap was running into. I've disabled the automatic focus redirection since the calendar has its own. * The calendar close button for screen readers was off-screen, because the dialog container has `position: static` and `overflow: auto`. Apart from the two issues above, I've also made it so the screen reader button's theme color matches the one of the calendar. This is mostly so the button doesn't look out of place if the calendar has a different theme and the user tabs into it. (cherry picked from commit f7bd224)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…I mode (angular#21228) Resolves the following accessibility issues when the datepicker is in touch UI mode: * Focus was going directly to the close button, because that's the first element that the dialog's focus trap was running into. I've disabled the automatic focus redirection since the calendar has its own. * The calendar close button for screen readers was off-screen, because the dialog container has `position: static` and `overflow: auto`. Apart from the two issues above, I've also made it so the screen reader button's theme color matches the one of the calendar. This is mostly so the button doesn't look out of place if the calendar has a different theme and the user tabs into it.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the following accessibility issues when the datepicker is in touch UI mode:
position: staticandoverflow: auto.Apart from the two issues above, I've also made it so the screen reader button's theme color matches the one of the calendar. This is mostly so the button doesn't look out of place if the calendar has a different theme and the user tabs into it.