Skip to content

WIP: feat: add date adapter for luxon #19326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

FrankiePo
Copy link
Contributor

@FrankiePo FrankiePo commented May 11, 2020

continue work after @crisbeto #14681
issues: #12321 #10427

History:
There was already implemented LuxonDateAdapter. The work was blocked with no reason.
Old PR is really outdated. I'm going to fix all conflicts, but I need to know.

What is the Angular team opinion about this module?
Will the module ever going to happen to users?

crisbeto and others added 3 commits May 11, 2020 22:46
Adds the `LuxonDateAdapter` that can be used to work with Luxon dates in the `MatDatepicker`.
@FrankiePo FrankiePo requested review from jelbourn and a team as code owners May 11, 2020 21:21
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label May 11, 2020
@FrankiePo FrankiePo closed this May 12, 2020
@jelbourn
Copy link
Member

Adding more official date adapters is blocked on doing a more comprehensive research/design doc that captures the differences/pros/cons between different datetime/i18n libraries (moment, luxon, date-fns, day.js), and making recommendations around what people should use in which circumstances. We just unfortunately haven't had the capacity to work on this.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants