Skip to content

ci: update gcp_token #16436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

ci: update gcp_token #16436

merged 1 commit into from
Jul 3, 2019

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: merge safe labels Jul 3, 2019
@josephperrott josephperrott requested a review from devversion July 3, 2019 13:23
@josephperrott josephperrott requested a review from jelbourn as a code owner July 3, 2019 13:23
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 3, 2019
@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Jul 3, 2019
crisbeto
crisbeto approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 3, 2019
@Aboisier Aboisier mentioned this pull request Jul 3, 2019
Merged
@andrewseguin andrewseguin merged commit 5b3e846 into angular:master Jul 3, 2019
@josephperrott josephperrott deleted the gcp_token-update branch July 3, 2019 15:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josephperrott @crisbeto @devversion @googlebot @andrewseguin