feat(cdk-experimental/testing): Adds a HarnessPredicate class
#16319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
crisbeto
reviewed
Jun 18, 2019
src/cdk-experimental/testing/protractor/protractor-harness-environment.ts
Show resolved
Hide resolved
src/cdk-experimental/testing/tests/harnesses/sub-component-harness.ts
Outdated
Show resolved
Hide resolved
jelbourn
reviewed
Jun 19, 2019
| export class SubComponentHarness extends ComponentHarness { | ||
| static readonly hostSelector = 'test-sub'; | ||
|
|
||
| static with(options: {title?: string | RegExp, itemCount?: number} = {}) { |
There was a problem hiding this comment.
Should we add an interface for supporting this with pattern to more formally codify it?
There was a problem hiding this comment.
I like this pattern and I think that Harness authors should follow it, but the actual options may differ based on the particular harness being implemented, and some harnesses might not even need a with method.
Maybe we can just say its a recommended convention and do it in all of our component harnesses where it makes sense?
jelbourn
added
pr: lgtm
action: merge
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…lar#16319) This enables users of harness authors to provide an API for querying harnesses based on arbitrary state as given by predicate functions.
andrewseguin
pushed a commit
that referenced
this pull request
Jul 2, 2019
This enables users of harness authors to provide an API for querying harnesses based on arbitrary state as given by predicate functions.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HarnessPredicateclass can be used to more easily search for component instances for aComponentHarnessthat meet certain criteria (e.g. get aMatButtonHarnesswith specific button text).