Skip to content

docs(snack-bar): make custom component example more user-friendly #15116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 7, 2019

Adds the ability to control the duration of the snack bar in the custom snack bar demo. Also bumps the default duration so people have more time to read it.

Fixes #15043.

@crisbeto crisbeto added docs This issue is related to documentation pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 7, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner February 7, 2019 17:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 7, 2019
@@ -1,3 +1,8 @@
<mat-form-field>
<mat-label>Snack bar duration</mat-label>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snack bar duration (seconds) ?

And then handle the * 1000 in the code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Changed.

Adds the ability to control the duration of the snack bar in the custom snack bar demo. Also bumps the default duration so people have more time to read it.

Fixes angular#15043.
@crisbeto crisbeto force-pushed the 15043/snack-bar-example branch from 848ea8b to 58f916c Compare February 7, 2019 17:54
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 7, 2019
@jelbourn jelbourn merged commit d69bc45 into angular:master Feb 7, 2019
jelbourn pushed a commit that referenced this pull request Feb 11, 2019
…5116)

Adds the ability to control the duration of the snack bar in the custom snack bar demo. Also bumps the default duration so people have more time to read it.

Fixes #15043.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snackbar examples disappear with no ability to adjust timing
3 participants