Skip to content

docs(cdk-stepper): add guide to create stepper #14710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2019
Merged

docs(cdk-stepper): add guide to create stepper #14710

merged 3 commits into from
Jan 16, 2019

Conversation

Mokkapps
Copy link

@Mokkapps Mokkapps commented Jan 3, 2019

  • Added guide how to create a custom stepper using the CDK
  • Added a material example to demonstrate the custom CDK stepper
  • Made steps from CdkStepper public as it is necessary to build
    a custom stepper

@Mokkapps Mokkapps requested a review from jelbourn as a code owner January 3, 2019 10:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 3, 2019
@Mokkapps
Copy link
Author

Mokkapps commented Jan 3, 2019

@mmalerba: This is the PR as discussed in #8993

@crisbeto crisbeto added docs This issue is related to documentation pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 3, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 4, 2019
@ngbot
Copy link

ngbot bot commented Jan 4, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@Mokkapps
Copy link
Author

Mokkapps commented Jan 4, 2019

CI fails due to a change in the stepper public API. How can I accept the new generated API as golden file? Is this something I have to do locally?

@mmalerba
Copy link
Contributor

mmalerba commented Jan 4, 2019

You can run the following command to accept:

bazel run //tools/public_api_guard:cdk_stepper_api.accept

* Added guide how to create a custom stepper using the CDK
* Added a material example to demonstrate the custom CDK stepper
* Made steps from CdkStepper public as it is necessary to build
a custom stepper
@jelbourn
Copy link
Member

I think this might be a bit too specific to be under Guides and instead makes more sense in the cdk component overview. @mmalerba thoughts?

@mmalerba
Copy link
Contributor

@jelbourn I was thinking of it as a similar thing to this guide: https://material.angular.io/guide/creating-a-custom-form-field-control

The overview pages, at least the way they are today, are more of just discussing each part of the API and what you can do with it, rather than taking you through a more complex example step by step.

@ngbot
Copy link

ngbot bot commented Jan 11, 2019

Hi @Mokkapps! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

1 similar comment
@ngbot
Copy link

ngbot bot commented Jan 11, 2019

Hi @Mokkapps! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@vivian-hu-zz vivian-hu-zz merged commit f6d0ea8 into angular:master Jan 16, 2019
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
* docs(cdk-stepper): add guide to create stepper

* Added guide how to create a custom stepper using the CDK
* Added a material example to demonstrate the custom CDK stepper
* Made steps from CdkStepper public as it is necessary to build
a custom stepper

* Review comments
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
* docs(cdk-stepper): add guide to create stepper

* Added guide how to create a custom stepper using the CDK
* Added a material example to demonstrate the custom CDK stepper
* Made steps from CdkStepper public as it is necessary to build
a custom stepper

* Review comments
vivian-hu-zz pushed a commit that referenced this pull request Jan 18, 2019
* docs(cdk-stepper): add guide to create stepper

* Added guide how to create a custom stepper using the CDK
* Added a material example to demonstrate the custom CDK stepper
* Made steps from CdkStepper public as it is necessary to build
a custom stepper

* Review comments
mmalerba pushed a commit to mmalerba/components that referenced this pull request Jan 22, 2019
* docs(cdk-stepper): add guide to create stepper

* Added guide how to create a custom stepper using the CDK
* Added a material example to demonstrate the custom CDK stepper
* Made steps from CdkStepper public as it is necessary to build
a custom stepper

* Review comments
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
@Mokkapps Mokkapps deleted the patch-1 branch September 10, 2019 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants