build: package material api docs into npm package #14508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn,
josephperrott and
mmalerba
as code owners
googlebot
added
the
cla: yes
devversion
commented
Dec 13, 2018
| # it's own entry-point. TODO(devversion): Support sub API docs for entry-points | ||
| if package_name == "material": | ||
| expected_outputs += [ | ||
| ctx.actions.declare_file("%s/%s-%s.html" % (output_dir_name, package_name, "ripple")) |
There was a problem hiding this comment.
@jelbourn I didn't bother too much about it (yet), because I want to get this going now. I will follow-up on this later as a low priority.
jelbourn
reviewed
Dec 13, 2018
devversion
added
needs: discussion
devversion
force-pushed
the
build/package-material-api-docs-npm-package
branch
from
8825bfd to
4339219
Compare
|
@jelbourn This would be ready for review. I have some plans to reduce the Bazel arguments overhead, but I want to address this in a follow-up if that's okay. |
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.