-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(menu): allow text wrapping in menu items #14503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@crisbeto this is failing presubmit because |
@jelbourn working around that one would be slightly error prone since we use that mixin in a few places. I remember doing a PostCSS plugin for AngularJS Material where stripped these duplicate properties. Would it be worth porting it to the Material build? |
That wouldn't work with the Google setup for Angular (vs. AngularJS). With Angular, all the Sass sources are compiled with Google's infrastructure (bazel) vs. AngularJS where we just copied in the CSS output. |
4d3ca2a
to
91e40bd
Compare
I've reworked it to avoid the issue @jelbourn. |
Allows for the text inside menu items to wrap, instead of having it be truncated. The text was being truncated as a limitation on `mat-select` and `mat-autocomplete`, however we don't have the same limitation on `mat-menu`.
91e40bd
to
bfcc33a
Compare
Closing since this is supported in the MDC version of the menu. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Allows for the text inside menu items to wrap, instead of having it be truncated. The text was being truncated as a limitation on
mat-select
andmat-autocomplete
, however we don't have the same limitation onmat-menu
.Note: this is a resubmit of #11430.