Skip to content

fix(menu): allow text wrapping in menu items #14503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

crisbeto
Copy link
Member

Allows for the text inside menu items to wrap, instead of having it be truncated. The text was being truncated as a limitation on mat-select and mat-autocomplete, however we don't have the same limitation on mat-menu.

Note: this is a resubmit of #11430.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 13, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner December 13, 2018 17:34
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2018
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 13, 2018
@jelbourn
Copy link
Member

@crisbeto this is failing presubmit because .mat-menu-panel has height declared multiple times in one definition (Google's CSS minifier errors on this)

@crisbeto
Copy link
Member Author

@jelbourn working around that one would be slightly error prone since we use that mixin in a few places. I remember doing a PostCSS plugin for AngularJS Material where stripped these duplicate properties. Would it be worth porting it to the Material build?

@jelbourn
Copy link
Member

That wouldn't work with the Google setup for Angular (vs. AngularJS). With Angular, all the Sass sources are compiled with Google's infrastructure (bazel) vs. AngularJS where we just copied in the CSS output.

@crisbeto crisbeto force-pushed the menu-item-text-wrap-resubmit branch from 4d3ca2a to 91e40bd Compare December 21, 2018 18:53
@crisbeto
Copy link
Member Author

I've reworked it to avoid the issue @jelbourn.

@mmalerba mmalerba added the aaa label Apr 25, 2019
@mmalerba mmalerba removed the aaa label Apr 25, 2019
@crisbeto crisbeto added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Aug 5, 2019
Allows for the text inside menu items to wrap, instead of having it be truncated. The text was being truncated as a limitation on `mat-select` and `mat-autocomplete`, however we don't have the same limitation on `mat-menu`.
@crisbeto crisbeto force-pushed the menu-item-text-wrap-resubmit branch from 91e40bd to bfcc33a Compare March 8, 2020 19:21
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@andrewseguin andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021
@crisbeto
Copy link
Member Author

Closing since this is supported in the MDC version of the menu.

@crisbeto crisbeto closed this Feb 26, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants