-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix/dynamically changing autocomplete #14402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/dynamically changing autocomplete #14402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @thomaspink can you rename the PR to the same as the original one?
@crisbeto Sure; Done |
@thomaspink I think they had some custom logic to show loading spinners and things. It's probably their app that needs to be updated, not this PR. |
@mmalerba Good to know. thanks for the investigation. |
@crisbeto What do i have to do solve the "commit message fixup"? Squash the commits? |
If you hover over the label, it says that it's for the caretaker. |
Change commit message to |
Hi @thomaspink! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
Hi @thomaspink! This PR has merge conflicts due to recent upstream merges. |
ef235f0
to
e851199
Compare
@crisbeto after rebasing the api check fails. There are only minor differences between the golden file and the changed one in the PR.
Is there something i have to change/do there? |
You can run |
e851199
to
1483b0f
Compare
@thomaspink this PR has fallen out of date, could you please rebase this PR? |
This PR is being closed due to inactivity and needing rebase for a very long time. Please feel free to re-open the change after rebasing and we can take another look at getting it merged. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fixes #13812
This PR is a reopened copy of #13814 because of an accidental merge to master despite breaking some internal google apps.
@mmalerba can you provide the error or some information why this PR did break these apps?