Skip to content

fix(material/icon): clip overflowing icon elements #12429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2022
Merged

fix(material/icon): clip overflowing icon elements #12429

merged 1 commit into from
Mar 10, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 29, 2018 •
edited
Loading

Clips any elements that are overflowing an icon. This avoids issues where parts of the icon could stick out and layouts.

Fixes #11826.

BREAKING CHANGE:
mat-icon elements now have overflow: hidden.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 29, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner July 29, 2018 14:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 29, 2018
jelbourn
jelbourn approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added target: major This PR is targeted for the next major release pr: lgtm action: merge The PR is ready for merge by the caretaker and removed target: patch This PR is targeted for the next patch release labels Jul 30, 2018
@jelbourn
Copy link
Member

I think to be safe this one should be major and have a breaking change notice in case anyone was depending on the previous behavior

@crisbeto crisbeto added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Oct 18, 2018
@crisbeto crisbeto force-pushed the 11826/icon-overflow branch from 2dc484f to 39d08fc Compare January 3, 2019 15:34
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 30, 2019
@crisbeto crisbeto force-pushed the 11826/icon-overflow branch from 39d08fc to 88f7ccb Compare July 7, 2019 15:07
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels May 20, 2020
@crisbeto
Copy link
Member Author

Bumping to a P2, because we've had multiple reports about this now.

@jelbourn jelbourn added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels May 26, 2020
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@crisbeto
fix(material/icon): clip overflowing icon elements
022dfc9 
Clips any elements that are overflowing an icon. This avoids issues where parts of the icon could stick out and layouts.

Fixes angular#11826.
@crisbeto crisbeto force-pushed the 11826/icon-overflow branch from da2793a to 022dfc9 Compare March 4, 2022 08:42
@crisbeto crisbeto changed the title fix(icon): clip overflowing icon elements fix(material/icon): clip overflowing icon elements Mar 4, 2022
@andrewseguin andrewseguin merged commit 025a534 into angular:master Mar 10, 2022
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 25, 2022
Closed
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
@crisbeto @forsti0506
fix(material/icon): clip overflowing icon elements (angular#12429)
77734e0 
Clips any elements that are overflowing an icon. This avoids issues where parts of the icon could stick out and layouts.

Fixes angular#11826.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-icon-button hover area bug
5 participants
@crisbeto @jelbourn @googlebot @mmalerba @andrewseguin