Skip to content

fix(schematic): parse5 v5.0.0 requires different parse options #12028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Jul 11, 2018
Merged

fix(schematic): parse5 v5.0.0 requires different parse options #12028

merged 1 commit into from Jul 11, 2018

Conversation

jerryorta-dev
Copy link
Contributor

The dependency parse5 v5.0.0 has different parse option properties than v4.0.0.

Fixes #12027

@jerryorta-dev jerryorta-dev requested a review from amcdnl as a code owner July 3, 2018 04:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 3, 2018
devversion
devversion approved these changes Jul 7, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (see this commit and this one)

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 7, 2018
jelbourn
jelbourn approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 118344e into angular:master Jul 11, 2018
@matippetts matippetts mentioned this pull request Jul 12, 2018
Closed
@Razenbull Razenbull mentioned this pull request Jul 12, 2018
Closed
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@jerryorta-dev @victoriaaa234
fix(schematic): parse5 v5.0.0 requires different parse options (#12028)
f34a651 
Fixes #12027
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@IustinT IustinT IustinT approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schematics: ng add throws startTag error
5 participants
@jerryorta-dev @jelbourn @devversion @IustinT @googlebot