Skip to content

fix(slider): support two-way binding for value #12003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 1, 2018

Currently we support having a two-way binding via ngModel, but not through the value binding. These changes add support for a two-way binding on the value.

Currently we support having a two-way binding via `ngModel`, but not through the `value` binding. These changes add support for a two-way binding on the `value`.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 1, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner July 1, 2018 11:03
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 1, 2018
@raza2022
Copy link

raza2022 commented Jul 2, 2018

+100 ❤️

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 3, 2018
@jelbourn jelbourn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 11, 2018
@jelbourn jelbourn merged commit de107b7 into angular:master Jul 11, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
Currently we support having a two-way binding via `ngModel`, but not through the `value` binding. These changes add support for a two-way binding on the `value`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants