fix(card): disable all animations when using NoopAnimationsModule #11538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto could you rebase this one? Just having an issue with the sync script since the sha is older |
|
Done. |
crisbeto
force-pushed
the
10590/card-transition
branch
from
99f5c65 to
e9eabcf
Compare
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbeto
force-pushed
the
10590/card-transition
branch
from
e9eabcf to
bac12e6
Compare
andrewseguin
added
P3
Fixes the card `box-shadow` transition not being disabled when it's inside something with the `NoopAnimationsModule`. Relates to angular#10590.
mmalerba
force-pushed
the
10590/card-transition
branch
from
bac12e6 to
f8bfe0f
Compare
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…gular#11538) * fix(card): disable all animations when using NoopAnimationsModule Fixes the card `box-shadow` transition not being disabled when it's inside something with the `NoopAnimationsModule`. Relates to angular#10590. * fix lint * fix api test
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the card
box-shadowtransition not being disabled when it's inside something with theNoopAnimationsModule.Relates to #10590.