-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(form-field): disable all animations when using NoopAnimationsModule #11371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -117,6 +118,7 @@ export const MAT_FORM_FIELD_DEFAULT_OPTIONS = | |||
'[class.ng-valid]': '_shouldForward("valid")', | |||
'[class.ng-invalid]': '_shouldForward("invalid")', | |||
'[class.ng-pending]': '_shouldForward("pending")', | |||
'[class._mat-animation-noopable]': '!_animationsEnabled', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the class name we used in other components? The _
seems unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I kept it for consistency with the other components, but I'm not sure where the underscore comes from @josephperrott.
@crisbeto needs rebase |
81bb4f1
to
935c6ed
Compare
Rebased. |
@crisbeto looks like tests are failing |
Disables all of the CSS-based animations in the form field when using the `NoopAnimationsModule`. Relates to angular#10590.
935c6ed
to
d042b15
Compare
CI failures should be sorted out now. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Disables all of the CSS-based animations in the form field when using the
NoopAnimationsModule
.Relates to #10590.