-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat: add forRoot
to modules
#1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Component({ | ||
*my-app-module.ts* | ||
```ts | ||
import {MdGridLisTModule} from '@angular2-material/gridlist/grislist'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: Capital T
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You definitely saw it already, but grislist
seems also to be invalid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
looks reasonable to me. no red flags :) |
972af53
to
e7917b5
Compare
e7917b5
to
91a7e5e
Compare
Unit tests for dialog and tooltip are failing now, haven't figured out why yet... |
Apparently they only fail when I'm on the bus. |
Closing this in favor of #1122, which is a manual rebase because Jeremy is in transit. |
stuck in trying to get this app to run, I cloned the repo and run npm install, when I execute ng server --port 4301, i get this error for all the packages. ERROR in Entry module not found: Error: Can't resolve 'C:\dev\ng2\material2-app\material2-app\src\polyfills.ts' ERROR in ./src/main.ts I just post these 2, but it is basically the same for all modules, I just don't know why it can't load the modules. If this is not the right place to ask for this kind of help, any info would be appreciated... thanks |
@pdecembre Nothing to do with this PR, please file an issue for issues. To answer your question though; we do not use angular-cli anymore. Please use gulp. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
R: @kara @hansl
Also remove deprecated
MD_XXX_DIRECTIVES
.@robwormald or @IgorMinar can one of you take a look at this and make sure I'm doing "the right thing" WRT use of
forRoot
, especially as it pertains to theMaterialModule
?