Skip to content

feat: add forRoot to modules #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jelbourn
Copy link
Member

R: @kara @hansl

Also remove deprecated MD_XXX_DIRECTIVES.

@robwormald or @IgorMinar can one of you take a look at this and make sure I'm doing "the right thing" WRT use of forRoot, especially as it pertains to the MaterialModule?

@jelbourn jelbourn added this to the alpha.8 milestone Aug 23, 2016
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2016
@Component({
*my-app-module.ts*
```ts
import {MdGridLisTModule} from '@angular2-material/gridlist/grislist';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Capital T

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You definitely saw it already, but grislist seems also to be invalid.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@IgorMinar
Copy link
Contributor

looks reasonable to me. no red flags :)

@jelbourn
Copy link
Member Author

Unit tests for dialog and tooltip are failing now, haven't figured out why yet...

@jelbourn
Copy link
Member Author

Apparently they only fail when I'm on the bus.

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 25, 2016
@hansl
Copy link
Contributor

hansl commented Aug 25, 2016

Closing this in favor of #1122, which is a manual rebase because Jeremy is in transit.

@hansl hansl closed this Aug 25, 2016
@pdecembre
Copy link

stuck in trying to get this app to run, I cloned the repo and run npm install, when I execute ng server --port 4301, i get this error for all the packages.

ERROR in Entry module not found: Error: Can't resolve 'C:\dev\ng2\material2-app\material2-app\src\polyfills.ts'

ERROR in ./src/main.ts
Module not found: Error: Can't resolve '@angular2-material/button-toggle/button-toggle' in 'C:\dev\ng2\material2-app\material2-app\src' @ ./src/main.ts 16:22-79 @ multi main

I just post these 2, but it is basically the same for all modules, I just don't know why it can't load the modules. If this is not the right place to ask for this kind of help, any info would be appreciated... thanks

@hansl
Copy link
Contributor

hansl commented Aug 26, 2016

@pdecembre Nothing to do with this PR, please file an issue for issues.

To answer your question though; we do not use angular-cli anymore. Please use gulp.

@angular angular locked and limited conversation to collaborators Aug 26, 2016
@jelbourn jelbourn deleted the modules-forroot branch September 13, 2017 04:36
@angular angular unlocked this conversation Sep 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants