Skip to content

MatAutocompleteTrigger.panelClosingActions emmiting even if the panel isn't being closed #8763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julianobrasil opened this issue Dec 1, 2017 · 1 comment · Fixed by #8774
Closed

MatAutocompleteTrigger.panelClosingActions emmiting even if the panel isn't being closed #8763

julianobrasil opened this issue Dec 1, 2017 · 1 comment · Fixed by #8774
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@julianobrasil
Copy link
Contributor

julianobrasil commented Dec 1, 2017 •
edited
Loading

Bug, feature request, or proposal:

Bug?

What is the expected behavior?

MatAutocompleteTrigger.panelClosingActions should emmit only upon a closing panel action

What is the current behavior?

It's emmiting a void when the input is focused and the user hit tab key to leave it, even if the panel is already closed.

image

What are the steps to reproduce?

https://stackblitz.com/edit/autocomplete-force-selection

Open the Developer Tools, select the input and hit tab. It will emmit an undefined.

Is there anything else we should know?

I'm not sure if it's covered by #8533 (haven't taken a look at the code)

cc @crisbeto
@julianobrasil julianobrasil changed the title MatAutocompleteTrigger.panelClosingActions emmiting when blur with tab key MatAutocompleteTrigger.panelClosingActions emmiting even if the panel isn't being closed Dec 1, 2017
@crisbeto crisbeto self-assigned this Dec 2, 2017
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions labels Dec 2, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 2, 2017
@crisbeto
fix(autocomplete): panelClosingActions emitting when tabbing away fro…
6267ea5 
…m a closed autocomplete

Fixes the `MatAutocompleteTrigger.panelClosingActions` emitting when the user tabs away from an autocomplete that was closed already.

Fixes angular#8763.
@crisbeto crisbeto mentioned this issue Dec 2, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 2, 2017
@crisbeto
fix(autocomplete): panelClosingActions emitting when tabbing away fro…
0cc628e 
…m a closed autocomplete

Fixes the `MatAutocompleteTrigger.panelClosingActions` emitting when the user tabs away from an autocomplete that was closed already.

Fixes angular#8763.
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 10, 2017
@crisbeto
fix(autocomplete): panelClosingActions emitting when tabbing away fro…
d3d3417 
…m a closed autocomplete

Fixes the `MatAutocompleteTrigger.panelClosingActions` emitting when the user tabs away from an autocomplete that was closed already.

Fixes angular#8763.
andrewseguin pushed a commit that referenced this issue Dec 13, 2017
@crisbeto @andrewseguin
fix(autocomplete): panelClosingActions emitting when tabbing away fro…
92dcd76 
…m a closed autocomplete (#8774)

Fixes the `MatAutocompleteTrigger.panelClosingActions` emitting when the user tabs away from an autocomplete that was closed already.

Fixes #8763.
andrewseguin pushed a commit to andrewseguin/components that referenced this issue Dec 19, 2017
@crisbeto @andrewseguin
fix(autocomplete): panelClosingActions emitting when tabbing away fro…
3066929 
…m a closed autocomplete (angular#8774)

Fixes the `MatAutocompleteTrigger.panelClosingActions` emitting when the user tabs away from an autocomplete that was closed already.

Fixes angular#8763.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @julianobrasil