-
Notifications
You must be signed in to change notification settings - Fork 6.8k
bug(github docs): mention @angular/cdk in material installation instructions #5552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We should really just remove this section from the README and point to the getting started guide. |
I think removing the installation part entirely and leaving the Getting Started part is sufficient. I'll just include the latest builds installation in the Getting Started part:
|
@jelbourn, I built a PR with these modifications: #5555 (comment). Take a look to see whether it's good. |
What about @angular/animations, is that not a required package as well? |
…5555) * includes @angular/cdk in github material installation instructions * Mention the latest builds instructions Add the latest builds instructions in the installation section (Step 1). * Delete the installation section The Getting Started section has all the information necessary to proceed with installations: #5552 (comment)
@dauledk, it was already in Getting Started page on github. |
…ngular#5555) * includes @angular/cdk in github material installation instructions * Mention the latest builds instructions Add the latest builds instructions in the installation section (Step 1). * Delete the installation section The Getting Started section has all the information necessary to proceed with installations: angular#5552 (comment)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
github first page should specify
@angular/material
depends on@angular/cdk
What is the current behavior?
The intallation instructions on github mentions the
@angular/cdk
dependency just for the latest builds part.The text was updated successfully, but these errors were encountered: