-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Feature(MdSidenav): add scroll block strategy #4625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Not to be dismissive or critical, but isn't this idea in violation of Material Design specs for navigation drawers?
I believe the reason for not allowing full view width is to be able to cancel/dismiss the sidenav by clicking outside it, since a full height sidenav in 'over' mode obscures the hamburger menu icon. |
@gtranter „spanning across the visible viewport“ refers to the backdrop. The sidensv would no change in dimensions, but would simply be placed fixed in position and prevent the user from scroling the background |
@macjohnny Thanks for the clarification. I am already seeing this behavior in 2.0.0-beta.12 using mat-sidenav in 'over' mode. The only deficiency from the issue description that I can see is that the sidenav does not scroll when the mouse is over the backdrop - only when the mouse is over the sidenav. However, scrolling of the content area is blocked as desired. |
@gtranter thanks for your response. I guess the feature is implemented then. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Feature request
What is the expected behavior?
It should be possible to have a sidenav that spans across the visible viewport, i.e. 100vw and 100vh and blocks scrolling. The content of the sidenav should scroll instead of the body content.
See also #4500
What is the current behavior?
The sidenav backdrop expands with the containing content and still allows the user scroll.
What are the steps to reproduce?
How it is now:
http://embed.plnkr.co/zlg13xd1ukSDUa16aNqE/
How it should be:
What is the use-case or motivation for changing an existing behavior?
When using the sidenav as a navigation,
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular4, Material 2.0.0-beta.5
Is there anything else we should know?
An easy solution can be achieved with the following template / scss:
To be used in combination with the newly developed #4500 scroll block strategy.
The text was updated successfully, but these errors were encountered: