Skip to content

bug(schematics/theme-color): css file generation does not include --mat-sys-surface-container-low #30948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
rschulz-scisys opened this issue Apr 24, 2025 · 1 comment · Fixed by #30985
Assignees
Labels
area: ng-generate Schematics that generate code in user projects P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@rschulz-scisys
Copy link

rschulz-scisys commented Apr 24, 2025

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

when using the material schematics to generate a color theme, the resulting css file, when not creating scss, does not include the variable --mat-sys-surface-container-low (also missing in the high contrast part)

Reproduction

StackBlitz link:
Steps to reproduce:

  1. use the schematics like ng g @angular/material:theme-color
    2.enter any values
  2. when asked if to create an scss file, answer no
  3. check the resulting css file, the variable as described here https://material.angular.io/guide/system-variables#colors is missing

Expected Behavior

the css file should include a definiton for --mat-sys-surface-container-low also in the high contrast part

Actual Behavior

variable is not present

Environment

  • Angular: 19.2.11
  • CDK/Material: 19.2.11
  • Browser(s): irrelevant
  • Operating System (e.g. Windows, macOS, Ubuntu): macos
@rschulz-scisys rschulz-scisys added the needs triage This issue needs to be triaged by the team label Apr 24, 2025
@crisbeto crisbeto self-assigned this Apr 30, 2025
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: ng-generate Schematics that generate code in user projects and removed needs triage This issue needs to be triaged by the team labels Apr 30, 2025
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 30, 2025
Fixes that the `theme-color` schematic wasn't generating the `surface-container-low` token.

Fixes angular#30948.
crisbeto added a commit that referenced this issue Apr 30, 2025
…0985)

Fixes that the `theme-color` schematic wasn't generating the `surface-container-low` token.

Fixes #30948.

(cherry picked from commit 86ea718)
wildcardalice pushed a commit to wildcardalice/components that referenced this issue May 12, 2025
…gular#30985)

Fixes that the `theme-color` schematic wasn't generating the `surface-container-low` token.

Fixes angular#30948.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: ng-generate Schematics that generate code in user projects P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants