Skip to content

bug(Expansion panel): strong focus indicator not respacting shape + container-shape token not working #30350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardsengers opened this issue Jan 17, 2025 · 1 comment · Fixed by #30352
Assignees
Labels
area: material/expansion P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@richardsengers
Copy link

richardsengers commented Jan 17, 2025

Description

Expansion panels have a default container shape. When setting strong focus indicators, the corner of the strong focus-indicator are not rounded

Image

In this example, it's just a little bit, but since we have a container-shape token, this can get worse when setting the shape to full
https://m3.material.io/styles/shape/shape-scale-tokens

Issue 2
When setting the container-shape token to one of the values described by m3 https://m3.material.io/styles/shape/shape-scale-tokens nothing happens. It looks more like container-shape is a true or false token instead of one of the options decribed by m3

Reproduction

StackBlitz link: https://stackblitz.com/edit/lhvfsmcd?file=src%2Fstyles.scss
Steps to reproduce:

  1. Click on the first or last panel

Expected Behavior

  1. Strong focus indicator should also be rounded
  2. Token container-shape should have one of the 7 options described by m3

Actual Behavior

Strong focus indicator do not have a rounded corner
Setting container-shape to one of the 7 values removes the rounded corners

Environment

Angular CLI: 19.0.5
Node: 22.3.0
Package Manager: yarn 1.22.17
OS: win32 x64

Angular: 19.0.4
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router, service-worker

Package Version

@angular-devkit/architect 0.1900.5 (cli-only)
@angular-devkit/build-angular 19.0.5
@angular-devkit/core 19.0.5
@angular-devkit/schematics 19.0.5
@angular/cdk 19.0.3
@angular/cli 19.0.5
@angular/material 19.0.3
@angular/material-date-fns-adapter 19.0.3
@schematics/angular 19.0.5
rxjs 7.8.1
typescript 5.6.3
zone.js 0.15.0

@richardsengers richardsengers added the needs triage This issue needs to be triaged by the team label Jan 17, 2025
@crisbeto crisbeto self-assigned this Jan 18, 2025
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/expansion and removed needs triage This issue needs to be triaged by the team labels Jan 18, 2025
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 18, 2025
Fixes that the focus indicator had a different shape from the header.

Fixes angular#30350.
crisbeto added a commit that referenced this issue Jan 20, 2025
Fixes that the focus indicator had a different shape from the header.

Fixes #30350.
crisbeto added a commit that referenced this issue Jan 20, 2025
Fixes that the focus indicator had a different shape from the header.

Fixes #30350.

(cherry picked from commit d52c329)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/expansion P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants