Skip to content

fix(MdInput): placeholders don't float when MdInput value has bound expression #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0x-r4bbit opened this issue Dec 30, 2016 · 4 comments · Fixed by #2455
Closed

fix(MdInput): placeholders don't float when MdInput value has bound expression #2477

0x-r4bbit opened this issue Dec 30, 2016 · 4 comments · Fixed by #2455
Assignees

Comments

@0x-r4bbit
Copy link

Bug, feature request, or proposal:

When binding a value to MdInput using an expression, placeholder attribute (or md-placeholder) don't float when value is set, which results in placeholder text + input value to overlap. Also after focussing and blurring the input, the placeholder goes back to its original position. However, when using a static value, it works perfectly fine.

What is the expected behavior?

placeholder attribute (and/or MdPlaceholder) should float, also when initial MdInput value comes from an expression.

What are the steps to reproduce?

  1. Create a property on component (foo="bar")
  2. Bind property to MdInput and give it a placeholder (placeholder="Some Placeholder")

Here's a Plunk that reproduces the bug: https://plnkr.co/edit/NnwmYrakshZ5DEBkW27D?p=preview

Is there anything else we should know?

There's an issue that might be related to this bug. When setting form values programmatically, placeholder positions also aren't updated. This issue can be found here: #2441

Someone came up with a fix for that as well: crisbeto@72bc742

@devversion
Copy link
Member

Just confirmed that this will be fixed with #2455.

@devversion devversion self-assigned this Dec 30, 2016
@0x-r4bbit
Copy link
Author

@devversion Wow, thanks for the quick reply!! I haven't found that PR right away, would've otherwise not opened this issue. I'll leave it open though, until #2455 is merged!

Thanks so much!

@devversion
Copy link
Member

@PascalPrecht No worries. Thanks for the issue 😄 I will reference your issue, so it will be closed once the PR is merged.

OysteinAmundsen added a commit to FINTLabs/fint-admin-portal-backend that referenced this issue Jan 2, 2017
+ Fixed client api consumption.
+ upgraded angular/material (still suffers from angular/components#2477)
@kara kara closed this as completed in #2455 Jan 4, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants