Skip to content

test: karma should use sourcemaps. #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devversion opened this issue Mar 18, 2016 · 7 comments
Closed

test: karma should use sourcemaps. #203

devversion opened this issue Mar 18, 2016 · 7 comments
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone

Comments

@devversion
Copy link
Member

I don't know if this is possible, but I will file an issue to keep track on it.

At the moment, we always retrieve failure messages from the compiled javascript code.
image

This complicates debugging.

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Mar 18, 2016
@jelbourn jelbourn added this to the alpha.3 milestone Mar 18, 2016
@jelbourn
Copy link
Member

@hansl probably also relates to the cli

@devversion
Copy link
Member Author

@jelbourn No, we are just not initializing the sourcemaps in the karma files.

See the karma source

I'm trying to submit a PR, if encouraged.

@jelbourn
Copy link
Member

@devversion if you've got a fix in mind go for it.

@devversion
Copy link
Member Author

I'm still trying to get it running.

I'm failing with the sourcemaps, because it seems like there are not correct in the dist folder.

//# sourceMappingURL=../../../../components/button/button.js.map

Do you recall why these aren't correct?

@devversion
Copy link
Member Author

@jelbourn @hansl Yes, it seems like the CLI is applying some wrong / relative sourcemap paths to the distribution. Sorry I was a bit hasty.

@jelbourn
Copy link
Member

Tracking this on the CLI
angular/angular-cli#456

andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018
…lar#203)

Prevents the site from crashing on browsers that don't allow access to localStorage (e.g. IE11 or iOS Safari in private mode).
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

2 participants