Skip to content

Ripple positioning is off beneath the fold #1817

Closed
@kara

Description

@kara

To repro:

  1. Slow animations down in animations console (because we are not robots).
  2. Remove "fullscreen" attribute from demo app sidenav.
  3. Move button (or other ripple container) to the bottom of the page, so that you have to scroll to get to it.
  4. Click the button.

You can see that the ripple originates from the bottom and not the center of the click event. It also takes a bit longer to appear.

Edit: it looks like the height of the ripple foreground wasn't taking into account the scrollTop of the page. So the height would be off by as far as the user had scrolled, making the ripple huge and centered far below (which is why we were only seeing the top later). Should be fixable by subtracting the scroll offset from the pageX and pageY.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2The issue is important to a large percentage of users, with a workaround

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions