Skip to content

Commit 173cddd

Browse files
crisbetommalerba
authored andcommitted
chore(menu): switch to OnPush change detection (#5518)
Switches the `md-menu` and `md-menu-item` components to `OnPush` change detection. Relates to #5035.
1 parent 1efa594 commit 173cddd

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/lib/menu/menu-directive.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import {
1919
ViewChild,
2020
ViewEncapsulation,
2121
ElementRef,
22+
ChangeDetectionStrategy,
2223
} from '@angular/core';
2324
import {MenuPositionX, MenuPositionY} from './menu-positions';
2425
import {throwMdMenuInvalidPositionX, throwMdMenuInvalidPositionY} from './menu-errors';
@@ -35,6 +36,7 @@ import {ESCAPE} from '../core/keyboard/keycodes';
3536
selector: 'md-menu, mat-menu',
3637
templateUrl: 'menu.html',
3738
styleUrls: ['menu.css'],
39+
changeDetection: ChangeDetectionStrategy.OnPush,
3840
encapsulation: ViewEncapsulation.None,
3941
animations: [
4042
transformMenu,

src/lib/menu/menu-item.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {Component, ElementRef} from '@angular/core';
9+
import {Component, ElementRef, ChangeDetectionStrategy} from '@angular/core';
1010
import {Focusable} from '../core/a11y/focus-key-manager';
1111
import {CanDisable, mixinDisabled} from '../core/common-behaviors/disabled';
1212

@@ -31,8 +31,9 @@ export const _MdMenuItemMixinBase = mixinDisabled(MdMenuItemBase);
3131
'[attr.disabled]': 'disabled || null',
3232
'(click)': '_checkDisabled($event)',
3333
},
34+
changeDetection: ChangeDetectionStrategy.OnPush,
3435
templateUrl: 'menu-item.html',
35-
exportAs: 'mdMenuItem'
36+
exportAs: 'mdMenuItem',
3637
})
3738
export class MdMenuItem extends _MdMenuItemMixinBase implements Focusable, CanDisable {
3839

0 commit comments

Comments
 (0)