Skip to content

chore(): Fix for Travis master and adding a CI/CD pipeline #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 20, 2019
Merged

chore(): Fix for Travis master and adding a CI/CD pipeline #2072

merged 5 commits into from
May 20, 2019

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 13, 2019 •
edited
Loading

  • Yarn upgrade, go with TypeScript 3.1.6 for development
  • Drop the type on auditLog's scan, this can be implicit now and being explicit was angering TSC
  • Adding a CI/CD process using Cloud Build, see go/angularfire-releasing

jamesdaniels
jamesdaniels commented May 16, 2019
View reviewed changes
@jamesdaniels jamesdaniels added this to the 5.2.0 milestone May 20, 2019
@jamesdaniels jamesdaniels changed the title chore(): Quick fix for Travis master... chore(): Fix for Travis master and adding a CI/CD pipeline May 20, 2019
davideast
davideast approved these changes May 20, 2019
View reviewed changes
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesdaniels jamesdaniels merged commit 1c9ee1d into master May 20, 2019
@jamesdaniels jamesdaniels deleted the fix_travis branch May 20, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideast davideast davideast approved these changes

@jhuleatt jhuleatt Awaiting requested review from jhuleatt

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesdaniels @davideast @googlebot