docs(): authentication tutorial with ionic and rxjs compact for angularfire2 ^rc.10 #1721

hiepxanh · 2018-06-11T01:16:22Z

authentication with ionic and firebase

Checklist

Issue number for this PR: #1601 #1600 #1719 #1733
Docs included?: yes
Test units included?: no
In a clean directory, yarn install, yarn test run successfully? yes

Description

Updating our documentation on Ionic Authentication. it work with google and facebook

authentication with ionic and firebase

davideast

@hiepxanh Thank you so much for sending in this PR!

I have a few comments around formatting, capitalization, and small typos. Nothing major.

Don't worry about the number of comments. We don't have a formatting guide for these kind of docs so this was bound to happen.

Don't hesitate to ask me if you need clarity from a comment of mine.

davideast · 2018-06-20T11:33:54Z

docs/ionic/authentication.md

@@ -0,0 +1,94 @@
+# STEP 1: install this plugin: 


Use capitalization instead of uppercase for the word "step". I find that when something is placed in uppercase by itself too many times it can come off a bit aggressive.

davideast · 2018-06-20T11:34:16Z

docs/ionic/authentication.md

@@ -0,0 +1,94 @@
+# STEP 1: install this plugin: 
+```
+1) ionic cordova plugin add cordova-universal-links-plugin


Drop the numbers so it's copy and paste-able.

davideast · 2018-06-20T11:35:17Z

docs/ionic/authentication.md

+
+# STEP 2: Add Firebase to your Ionic
+
+  STEP 2.1:  [setup firebase to angular project] 


Instead of sub numbering the steps just place the action in bold.

Setup Firebase to the Angular Project

davideast · 2018-06-20T11:35:28Z

docs/ionic/authentication.md

+
+# STEP 2: Add Firebase to your Ionic
+
+  STEP 2.1:  [setup firebase to angular project] 


Link formatting is broken here

davideast · 2018-06-20T11:36:07Z

docs/ionic/authentication.md

+  STEP 2.1:  [setup firebase to angular project] 
+  (https://github.com/angular/angularfire2/blob/master/docs/install-and-setup.md)
+
+  STEP 2.2: To set up an Android app, go to [Firebase Console](https://console.firebase.google.com/) then 


Nitpick: Small typo "To set up in an Android app, go to..."

davideast · 2018-06-20T11:40:20Z

docs/ionic/authentication.md

+		return this.oauthSignIn(new firebase.auth.GoogleAuthProvider());
+	}
+
+        private oauthSignIn(provider: AuthProvider) {


The code formatting is off in this sample. Try pasting it into an editor to clean it up for you and then paste it back in here.

davideast · 2018-06-20T11:41:04Z

docs/ionic/authentication.md

+}
+```
+
+# Problem 1: 


I really like that you have a common problems section. Try using that title as the header:

Common problems

davideast · 2018-06-20T11:42:31Z

docs/ionic/authentication.md

+
+# Problem 1: 
+
+if you got error when build code like this:


Try: "If you received an error like this during a build"

davideast · 2018-06-20T11:42:58Z

docs/ionic/authentication.md

+# Problem 1: 
+
+if you got error when build code like this:
+`UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'manifest' of undefined`


Use a three backtick code block here:

UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'manifest' of undefined

davideast · 2018-06-20T11:43:19Z

docs/ionic/authentication.md

+if you got error when build code like this:
+`UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'manifest' of undefined`
+
+Please, using this fix from [issue](https://github.com/nordnet/cordova-universal-links-plugin/issues/134):


Try: "Use this fix from..."

hiepxanh · 2018-06-21T02:44:26Z

Yes sir! thank you for showing my fault. I'm on my way

davideast · 2018-06-21T03:33:11Z

No faults! We don't have clear guides on formats so there's going to be a bit of back and forth to get it into shape. You're doing great and we're really lucky to have docs contributed like this!

EdricChan03 · 2018-06-22T13:37:08Z

docs/ionic/authentication.md

+ STEP 3.1: In the Firebase console, open the **Dynamic Links** section at bottom left panel, setup by they instruction
+
+ STEP 3.2: add this to config.xml at root level of project:
+```


Add syntax highlighting perhaps?

```xml ```

EdricChan03 · 2018-06-22T13:37:52Z

docs/ionic/authentication.md

+
+# STEP 4: add login code:
+at login.service.ts add this function: 
+```


Syntax highlighting here as well

```ts ```

@davideast

thank you @davideast for guiding me to present the article better

hiepxanh · 2018-06-25T01:41:41Z

thank you @Chan4077 @davideast for guiding me to present the article better. �@davideast I was so pleased to receive your encouragement. Would you mind to help me to check my new update ?

hiepxanh · 2018-07-31T01:25:48Z

@davideast I already updated sir, can you check on my commit?

davideast · 2018-08-02T15:23:24Z

Thanks @hiepxanh!

hiepxanh · 2018-08-02T15:25:33Z

you're welcome. I'm happy to help

authentication tutorial with ionic

89d2fdf

authentication with ionic and firebase

googlebot added the cla: yes label Jun 11, 2018

davideast requested changes Jun 20, 2018

View reviewed changes

hiepxanh changed the title ~~authentication tutorial with ionic~~ doc(): Authentication tutorial with ionic Jun 21, 2018

hiepxanh changed the title ~~doc(): Authentication tutorial with ionic~~ docs(): authentication tutorial with ionic Jun 21, 2018

EdricChan03 reviewed Jun 22, 2018

View reviewed changes

hiepxanh added 2 commits June 25, 2018 08:33

fix typo error

f80b33e

thank you @davideast for guiding me to present the article better

small changes

92a4ef1

update rxjs-compat for angular v6

08e0ea4

hiepxanh changed the title ~~docs(): authentication tutorial with ionic~~ docs(): authentication tutorial with ionic and rxjs compact for angularfire2 ^rc.10 Jun 29, 2018

hiepxanh added 2 commits July 10, 2018 21:31

update for angularfire rc 11

c26fdc4

no shortcode

5d20099

Merge branch 'master' into master

ad2d142

davideast approved these changes Aug 2, 2018

View reviewed changes

davideast merged commit f2bfda9 into angular:master Aug 2, 2018

GulajavaMinistudio mentioned this pull request Aug 3, 2018

Update upstream TypescriptID/angularfire2#44

Merged


		# STEP 2: Add Firebase to your Ionic

		STEP 2.1: [setup firebase to angular project]

docs(): authentication tutorial with ionic and rxjs compact for angularfire2 ^rc.10 #1721

docs(): authentication tutorial with ionic and rxjs compact for angularfire2 ^rc.10 #1721

Uh oh!

Conversation

hiepxanh commented Jun 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Description

Uh oh!

davideast left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Common problems

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hiepxanh commented Jun 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davideast commented Jun 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hiepxanh commented Jun 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hiepxanh commented Jul 31, 2018

Uh oh!

davideast commented Aug 2, 2018

Uh oh!

hiepxanh commented Aug 2, 2018

Uh oh!

Uh oh!

hiepxanh commented Jun 11, 2018 •

edited

Loading

hiepxanh commented Jun 21, 2018 •

edited

Loading

davideast commented Jun 21, 2018 •

edited

Loading

hiepxanh commented Jun 25, 2018 •

edited

Loading