Skip to content

Set Firestore timestampsInSnapshots to true by default (added in Firebase 4.13) #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2018
Merged

Set Firestore timestampsInSnapshots to true by default (added in Firebase 4.13) #1629

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3b0b9c
feat(firestore): Support Firestore Settings, timestampsInSnapshots de…
jamesdaniels May 12, 2018
71220a2
Merge branch 'master' into firestore_settings
davideast May 12, 2018
b3a9892
Merge branch 'master' into firestore_settings
davideast May 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/firestore/firestore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { InjectionToken, NgZone, PLATFORM_ID } from '@angular/core';
import { FirebaseFirestore, CollectionReference, DocumentReference } from '@firebase/firestore-types';
import { FirebaseFirestore, CollectionReference, DocumentReference, Settings } from '@firebase/firestore-types';

import { Observable, Subscriber } from 'rxjs';
import { map, catchError } from 'rxjs/operators';
Expand All @@ -18,7 +18,9 @@ import { FirebaseAppConfigToken, FirebaseOptionsToken, FirebaseAppNameToken, _fi
* The value of this token determines whether or not the firestore will have persistance enabled
*/
export const EnablePersistenceToken = new InjectionToken<boolean>('angularfire2.enableFirestorePersistence');
export const FirestoreSettingsToken = new InjectionToken<Settings>('angularfire2.firestore.settings');

export const DefaultFirestoreSettings = {timestampsInSnapshots: true} as Settings;

/**
* A utility methods for associating a collection reference with
Expand Down Expand Up @@ -110,13 +112,16 @@ export class AngularFirestore {
@Optional() @Inject(FirebaseAppConfigToken) config:FirebaseAppConfig,
@Optional() @Inject(FirebaseAppNameToken) name:string,
@Optional() @Inject(EnablePersistenceToken) shouldEnablePersistence: boolean,
@Optional() @Inject(FirestoreSettingsToken) settings: Settings,
@Inject(PLATFORM_ID) platformId: Object,
zone: NgZone
) {
this.scheduler = new FirebaseZoneScheduler(zone, platformId);
this.firestore = zone.runOutsideAngular(() => {
const app = _firebaseAppFactory(options, name, config);
return app.firestore();
const app = _firebaseAppFactory(config, name);
const firestore = app.firestore();
firestore.settings(settings || DefaultFirestoreSettings);
return firestore;
});

this.persistenceEnabled$ = zone.runOutsideAngular(() =>
Expand Down