Skip to content

Update Auth's getting-starder.md #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Auth's getting-starder.md #1612

wants to merge 1 commit into from

Conversation

laulaaa
Copy link

@laulaaa laulaaa commented May 10, 2018

In firebase @4.12.0"
The function firebaseAuth.authState returns an Observable<firebase.User>

In firebase @4.13.1"
The function firebaseAuth.authState returns an Observable< User>
User comes from firebase/auth-types

In firebase @4.12.0"
The function firebaseAuth.authState returns an Observable<firebase.User> 

In firebase @4.13.1"
The function firebaseAuth.authState returns an Observable<User> 
User comes from @firebase/auth-types
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jamesdaniels
Copy link
Member

@laulaaa have a chance to look at the CLA yet?

@jamesdaniels
Copy link
Member

Thanks for the PR, I've changed the API interface for AngularFireAuth in #1642 though; closing since this will be outdated once we merge that. Feel free to continue doc changes and reopen when it makes sense.

Thanks for contributing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants