Skip to content

fix(storage): task promise fixes #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2018
Merged

fix(storage): task promise fixes #1430

merged 1 commit into from
Jan 18, 2018

Conversation

davideast
Copy link
Collaborator

@davideast davideast commented Jan 18, 2018 •
edited
Loading

Addressing some issues found relating around AngularFireUploadTask promises.

  • Resolve downloadUrl() for files larger than 256kb
  • task.then() returned a function that returns a promise rather than a promise.

@davideast davideast merged commit 11b36ad into angular:master Jan 18, 2018
@davideast davideast deleted the storage-fixes branch January 18, 2018 22:35
myspivey pushed a commit to myspivey/angularfire2 that referenced this pull request Apr 10, 2018
@davideast @myspivey
fix(storage): task promise fixes (angular#1430)
60b454e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davideast @googlebot