fix(afs): Don't filter empty changes (allow for null set), closes #1184 #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davideast
requested changes
Oct 4, 2017
There was a problem hiding this comment.
Another great PR, @jamesdaniels! I think we just need one more test that I described in the review. After that we should be good to go!
| const ref = afs.firestore.collection(`${randomCollectionName}`); | ||
| let names = await createRandomStocks(afs.firestore, ref, ITEMS); | ||
| const sub = pricefilter$.switchMap(price => { | ||
| return afs.collection(randomCollectionName, ref => price ? ref.where('price', '==', price) : ref).valueChanges() |
There was a problem hiding this comment.
It would be good to test multiple events: ['added', 'modified']. That way we can make sure we're not breaking anything with removing the .filter() in sortedChanges(). Ideally you would write a test that limits to two events and tests the proper emission of each event.
jamesdaniels
force-pushed
the
allow_empty_changes
branch
from
b5f613c to
1201da3
Compare
|
@davideast done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install,npm run build, andnpm testrun successfully? yesDescription
Per #1184 AFS is filtering empty sets from valueChanges(), this has been fixed.