Skip to content

fix(storage): unsubscribing from the upload progress will not cancel … #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2020
Merged

fix(storage): unsubscribing from the upload progress will not cancel … #2688

merged 1 commit into from
Nov 24, 2020

Conversation

jamesdaniels
Copy link
Member

  • unsubscribing from upload progress shouldn't cancel the upload, that was undefined behavior IMO
  • shareReplay the upload, so one could pick back up (say if they had upload progress | async on a view somewhere)

Closes #2685

@jamesdaniels jamesdaniels merged commit d845cdd into master Nov 24, 2020
@jamesdaniels jamesdaniels deleted the fix_upload_cancelation branch November 24, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

don't cancel the upload if you unsubscribe from AngularFireUploadTask.percentageChanges()
2 participants
@jamesdaniels @googlebot