Skip to content

null cast away in valueChanges() #1319

Closed
@timblakely

Description

@timblakely

AngularFire:

5.0.0-rc.3

If the document does not exist, this line returns action.payload.data() : null, which is in turn casted to T, dropping the null case. Seems like the return type for valueChanges() should be Observable<T|null>.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions