Skip to content

Commit e6c25d0

Browse files
committed
fix(core): Allow name + config deps to be optional
1 parent 7d2fd53 commit e6c25d0

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/core/firebase.app.module.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { InjectionToken, NgZone, NgModule } from '@angular/core';
1+
import { InjectionToken, NgZone, NgModule, Optional } from '@angular/core';
22

33
import { FirebaseOptionsToken, FirebaseAppNameToken, FirebaseAppConfigToken } from './angularfire2';
44

5-
import firebase from '@firebase/app';
5+
import { firebase } from '@firebase/app';
66
import { FirebaseApp as _FirebaseApp, FirebaseOptions, FirebaseAppConfig } from '@firebase/app-types';
77
import { FirebaseAuth } from '@firebase/auth-types';
88
import { FirebaseDatabase } from '@firebase/database-types';
@@ -35,7 +35,11 @@ export function _firebaseAppFactory(options: FirebaseOptions, name?: string, app
3535
const FirebaseAppProvider = {
3636
provide: FirebaseApp,
3737
useFactory: _firebaseAppFactory,
38-
deps: [ FirebaseOptionsToken, FirebaseAppNameToken, FirebaseAppConfigToken ]
38+
deps: [
39+
FirebaseOptionsToken,
40+
[new Optional(), FirebaseAppNameToken],
41+
[new Optional(), FirebaseAppConfigToken]
42+
]
3943
};
4044

4145
@NgModule({

0 commit comments

Comments
 (0)