Skip to content

refactor(compiler): Add a new helper method getPrimaryAngularDecorator. #47180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Aug 17, 2022

This helper accepts a class, and returns the primary Angular Decorator associated with that trait (e.g. the Component, Pipe, Directive, or NgModule decorator). This will be useful for the language service import project, which needs to edit import arrays inside the decorator.

@dylhunn dylhunn added state: WIP target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Aug 17, 2022
@ngbot ngbot bot modified the milestone: Backlog Aug 17, 2022
@dylhunn dylhunn force-pushed the compiler-apis-0 branch 4 times, most recently from 5f3a7d1 to a2edadb Compare August 17, 2022 23:28
@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Aug 17, 2022
@dylhunn dylhunn marked this pull request as ready for review August 17, 2022 23:29
@dylhunn
Copy link
Contributor Author

dylhunn commented Aug 18, 2022

TAP Presubmit is green -- all failures were flakes upon rerun.

@dylhunn dylhunn removed the request for review from pkozlowski-opensource August 18, 2022 02:41
@alxhub
Copy link
Member

alxhub commented Aug 18, 2022

As with the other PR, this should be a refactor commit as it does not implement a new public feature.

@dylhunn dylhunn changed the title feat(compiler): Add a new helper method getPrimaryAngularDecorator. refactor(compiler): Add a new helper method getPrimaryAngularDecorator. Aug 18, 2022
…or`.

This helper accepts a class, and returns the primary Angular Decorator associated with that trait (e.g. the Component, Pipe, Directive, or NgModule decorator). This will be useful for the language service import project, which needs to edit import arrays inside the decorator.
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 18, 2022
@dylhunn dylhunn removed the request for review from JoostK August 18, 2022 22:39
@dylhunn dylhunn added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 18, 2022
@alxhub
Copy link
Member

alxhub commented Aug 22, 2022

This PR was merged into the repository by commit fc97a41.

@alxhub alxhub closed this in fc97a41 Aug 22, 2022
alxhub pushed a commit that referenced this pull request Aug 22, 2022
…or`. (#47180)

This helper accepts a class, and returns the primary Angular Decorator associated with that trait (e.g. the Component, Pipe, Directive, or NgModule decorator). This will be useful for the language service import project, which needs to edit import arrays inside the decorator.

PR Close #47180
alxhub pushed a commit that referenced this pull request Aug 22, 2022
…or`. (#47180)

This helper accepts a class, and returns the primary Angular Decorator associated with that trait (e.g. the Component, Pipe, Directive, or NgModule decorator). This will be useful for the language service import project, which needs to edit import arrays inside the decorator.

PR Close #47180
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 22, 2022
@dylhunn dylhunn deleted the compiler-apis-0 branch October 17, 2022 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants