This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($browser): handle async href on url change in <=IE9 #9237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisirhc
force-pushed
the
feature/fix-legacy-browser-redirects
branch
from
41bb66d to
63bdb08
Compare
chrisirhc
changed the title
|
this looks reasonable to me. we should review more thoroughly and merge. |
|
@chrisirhc I applied this patch to v1.2.25 but it's still not fixed. Still got the $digest infinite loop |
|
I reviewed this and it looks good. @aygee do you have a reproduction? yours might be a different issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9235
Affects 1.2.25 and 1.3.x.