Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update version-info.js #6912

Closed
wants to merge 1 commit into from
Closed

Update version-info.js #6912

wants to merge 1 commit into from

Conversation

Bobdina
Copy link
Contributor

@Bobdina Bobdina commented Mar 30, 2014

replaced grep with match
Windows operating systems do not have grep by default

replaced grep with match
Windows operating systems do not have grep by default
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6912)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Bobdina Bobdina added cla: no and removed cla: yes labels Mar 30, 2014
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@Bobdina Bobdina added cla: yes and removed cla: no labels Mar 31, 2014
@tbosch tbosch self-assigned this Mar 31, 2014
@tbosch tbosch closed this in 50eb3b2 Mar 31, 2014
@tbosch
Copy link
Contributor

tbosch commented Mar 31, 2014

Thanks!
By the way, is the rest of the build OK besides this issue?

@Bobdina
Copy link
Contributor Author

Bobdina commented Apr 1, 2014

I had some more build issues with version 1.2.15 mostly related to the docs task, these issues were not present in the latest version. There were also issues with the java startup parameters for closure, but I couldn't determine if it was related to my setup or if it's a general windows issue.

In /lib/grunt/utils.js:
~The parameter -Xmx2g gave me a heap allocation error, presumably caused by running a 32 bit
java on a 64 bit windows system, changing this to -Xmx1g fixed it.
see "http://www.oracle.com/technetwork/java/hotspotfaq-138619.html#gc_heap_32bit" for more details.

~ I had to include the current path in the classpath list like so; (line 212)
'-cp .'+ classPathSep+'bower_components/closure-compiler/compiler.jar' + classPathSep +

Again, I didn't generate pull requests for these issues since I wasn't 100% sure what the best solution here is, or what the impact would be.

@tbosch
Copy link
Contributor

tbosch commented Apr 2, 2014

Ok, thanks for the notes!

jeffbcross pushed a commit that referenced this pull request Apr 3, 2014
Replaced grep with match
Windows operating systems do not have grep by default

Closes #6912.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants