Skip to content

chore: update blueprints to 2.0.0-alpha-47 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2015
Merged

chore: update blueprints to 2.0.0-alpha-47 #85

merged 3 commits into from
Dec 4, 2015

Conversation

cironunes
Copy link
Member

To do:

  • Fix karma-config-shim to handle deep folder structures
  • Fix service generator
  • Fix pipe generator
  • Fix component generator

Closes #84
Closes #78

cironunes
cironunes reviewed Dec 2, 2015
View reviewed changes
addon/ng2/blueprints/ng2/files/karma-test-shim.js
@@ -20,7 +20,7 @@ System.config({
}
});

System.import('angular2/src/core/dom/browser_adapter').then(function(browser_adapter) {
System.import('angular2/src/platform/browser/browser_adapter').then(function(browser_adapter) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to use just angular2/platform/browser/browser_adapter but it didn't work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use angular2/platform/browser instead

@cironunes cironunes mentioned this pull request Dec 2, 2015
Closed
@IgorMinar IgorMinar self-assigned this Dec 2, 2015
@cironunes cironunes force-pushed the update-blueprints-alpha-47 branch from 26ca595 to 2c6ba3c Compare December 3, 2015 15:10
@cironunes
Copy link
Member Author

@IgorMinar I've made all the requested changes, but it seems that TypeScript is not happy when we change from angular2/angular2 to angular2/core. I didn't investigate yet, do you have any insight?

@IgorMinar
Copy link
Contributor

I'll check out your branch today and will post back
On Thu, Dec 3, 2015 at 7:15 AM Ciro Nunes [email protected] wrote:

@IgorMinar https://github.com/IgorMinar I've made all the requested
changes, but it seems that TypeScript is not happy when we change from
angular2/angular2 to angular2/core. I didn't investigate yet, do you have
any insight?

—
Reply to this email directly or view it on GitHub
#85 (comment).

IgorMinar
IgorMinar reviewed Dec 4, 2015
View reviewed changes
addon/ng2/blueprints/pipe/files/src/app/pipes/__name__/__name__.ts
@@ -7,7 +7,7 @@ import {Pipe} from 'angular2/angular2';
export class <%= classifiedModuleName %> {

transform(value, args?) {
return value;
return !value;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see. you are trying to make the test pass. how about returning null and updating the test to that too

@cironunes cironunes force-pushed the update-blueprints-alpha-47 branch from c27681c to 1586d73 Compare December 4, 2015 12:22
@IgorMinar
Copy link
Contributor

Otherwise lgtm

@cironunes cironunes force-pushed the update-blueprints-alpha-47 branch from 1586d73 to 027429f Compare December 4, 2015 15:52
@cironunes cironunes merged commit 027429f into angular:master Dec 4, 2015
@cironunes cironunes deleted the update-blueprints-alpha-47 branch January 31, 2016 14:23
@mrudangit mrudangit mentioned this pull request Feb 26, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@IgorMinar IgorMinar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade blueprints to 2.0.0-alpha.47 Fix generators
2 participants
@cironunes @IgorMinar