Skip to content

feat(@ngtools/webpack): add lightweight decorator remover #8456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(@ngtools/webpack): add lightweight decorator remover #8456

wants to merge 1 commit into from

Conversation

clydin
Copy link
Member

@clydin clydin commented Nov 12, 2017

This adds a decorator removal transformer for the new Angular compiler plugin. The implementation is designed to be minimal to avoid a maintenance overhead. This PR also introduces a transformer class abstraction which simplifies the infrastructure code necessary to create a transformer.

@filipesilva filipesilva self-requested a review November 15, 2017 12:33
@filipesilva filipesilva self-assigned this Nov 15, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Nov 15, 2017
Based on @clydin's great work in angular#8456. I had to adapt it to use the StandardTransform model we use currently but the logic is his.

Should addressed the bigger AOT non-prod builds and memory consumptions in prod build.

Fix angular#8457
Partially adresses angular#5618
Supersedes angular#8456
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Nov 15, 2017
Based on @clydin's great work in angular#8456. I had to adapt it to use the StandardTransform model we use currently but the logic is his.

Should addressed the bigger AOT non-prod builds and memory consumptions in prod build.

Fix angular#8457
Partially adresses angular#5618
Supersedes angular#8456
hansl pushed a commit that referenced this pull request Nov 16, 2017
Based on @clydin's great work in #8456. I had to adapt it to use the StandardTransform model we use currently but the logic is his.

Should addressed the bigger AOT non-prod builds and memory consumptions in prod build.

Fix #8457
Partially adresses #5618
Supersedes #8456
@clydin clydin closed this Nov 16, 2017
Brocco pushed a commit that referenced this pull request Nov 16, 2017
Based on @clydin's great work in #8456. I had to adapt it to use the StandardTransform model we use currently but the logic is his.

Should addressed the bigger AOT non-prod builds and memory consumptions in prod build.

Fix #8457
Partially adresses #5618
Supersedes #8456
@clydin clydin deleted the decorator-remover branch November 17, 2017 16:25
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
Based on @clydin's great work in angular#8456. I had to adapt it to use the StandardTransform model we use currently but the logic is his.

Should addressed the bigger AOT non-prod builds and memory consumptions in prod build.

Fix angular#8457
Partially adresses angular#5618
Supersedes angular#8456
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants