fix: updated the ember-cli version to the latest release #80
Conversation
| @@ -35,7 +35,7 @@ | |||
| "broccoli-merge-trees": "^0.2.1", | |||
| "broccoli-writer": "^0.1.1", | |||
| "chalk": "^1.1.0", | |||
| "ember-cli": "ember-cli/ember-cli#ae5e72614e40f5e6dd57463e526c65da899fde07", | |||
| "ember-cli": "ember-cli/ember-cli#ef6b848b38d85037f917dcc14a6735df59a94ea7", | |||
There was a problem hiding this comment.
can we use the version number instead of the commit hash?
|
I'm fine with doing that, we can even pull in the latest version via npm directly instead of via github?
Either way will work just fine, and the necessary coding changes in the repo are already handled. |
|
Awesome! Please amend the commit changing to the exact version and it will be good to merge. |
Brocco
force-pushed
the
issue-73-ember-cli-version
branch
from
dabb431 to
447a63a
Compare
|
This also now includes the change that fixes a unit test failure issue |
|
@Brocco the best would be having them in two different commits. Can you just remove the change and fix the commit message? |
Brocco
force-pushed
the
issue-73-ember-cli-version
branch
from
34dca41 to
09543a7
Compare
|
lots of test failures. @Brocco can you please investigate? |
|
ping |
Brocco
force-pushed
the
issue-73-ember-cli-version
branch
from
09543a7 to
9c66c5f
Compare
Change the reference to ember-cli from a github reference to an npm ref via fixed version Add errorStream configuration in mock-ui test helper fixes angular#73
Brocco
force-pushed
the
issue-73-ember-cli-version
branch
from
9c66c5f to
10eae9e
Compare
|
Node v5 checks were failing had to update some broccoli package references, all is good now |
|
ci green, merged. Thanks @Brocco |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #73 by updating the ember-cli version to the latest release
https://github.com/ember-cli/ember-cli/releases/tag/v1.13.13
Minor build issue fixed via helper update to mock-ui.js (pulled directly from ember's helper class)