Add App Shell and Service Worker to --mobile flag #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbcross
force-pushed
the
app-shell
branch
2 times, most recently
from
e2da923 to
0c57317
Compare
|
Remaining Todos:
Commits:
|
jeffbcross
force-pushed
the
app-shell
branch
3 times, most recently
from
eaf5f38 to
6277b81
Compare
jeffbcross
changed the title
| @@ -0,0 +1,35 @@ | |||
| import {provide} from '@angular/core'; | |||
| // import {ROUTER_PROVIDERS} from '@angular/router-deprecated'; | |||
There was a problem hiding this comment.
do you want to keep those comments?
There was a problem hiding this comment.
I'll actually remove them for now since I still have to sort out the router upgrade.
For projects that use the --mobile flag, this will cause all third-party polyfills and the system-loader script to be concatenated into a single file that can be loaded via an async script tag. This is necessary for App Shell to work properly, so that rendering won't be blocked on synchronous script loading. Note: this change still loads app and library files individually. Follow-up work should be done to further improve loading performance.
The specs fail because they are trying to require angular-cli.json which is not valid JSON anymore, since it has an expression, <% isMobile %>, which is not inside a string.
jeffbcross
force-pushed
the
app-shell
branch
2 times, most recently
from
2a35ef9 to
1eebf56
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs handlebars support, probably some cleanup. Pairing with @hansl