Skip to content

chore(e2e): remove npm err output from e2e #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2016

Conversation

filipesilva
Copy link
Contributor

Currently, ng e2e output npm script error information in addition to protractor output when tests fail, for instance:

(...)
1) angular2-cli-quickstart App should display message saying app works
  - Expected 'My First Angular 2 App' to equal 'angular2-cli-quickstart works!'.

Executed 1 of 1 spec (1 FAILED) in 1 sec.
[01:50:23] I/launcher - 0 instance(s) of WebDriver still running
[01:50:23] I/launcher - chrome #01 failed 1 test(s)
[01:50:23] I/launcher - overall: 1 failed spec(s)
[01:50:23] E/launcher - Process exited with error code 1

npm ERR! Windows_NT 10.0.10586
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "e2e" "--" "config/protractor.conf.js"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7
npm ERR! code ELIFECYCLE
npm ERR! [email protected] e2e: `protractor "config/protractor.conf.js"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] e2e script 'protractor "config/protractor.conf.js"'.
npm ERR! This is most likely a problem with the angular2-cli-quickstart package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     protractor "config/protractor.conf.js"
npm ERR! You can get their info via:
npm ERR!     npm owner ls angular2-cli-quickstart
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     E:\dev\ideablade\testing\angular2-cli-quickstart\npm-debug.log

This PR removes that extra information and converts the command/task to Typescript.

@filipesilva filipesilva force-pushed the update-output-of-e2e branch from 92b24b0 to 1e0fcd7 Compare May 2, 2016 14:04
@filipesilva filipesilva merged commit 7b26538 into angular:master May 2, 2016
@filipesilva filipesilva deleted the update-output-of-e2e branch June 13, 2016 16:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants