fix: do not add ROUTER_PROVIDERS on generation. #565
Conversation
| import {environment} from './app/environment'; | ||
| import {<%= jsComponentName %>App} from './app/<%= htmlComponentName %>.component'; | ||
|
|
||
| if (environment.production) { | ||
| enableProdMode(); | ||
| } | ||
|
|
||
| bootstrap(<%= jsComponentName %>App); | ||
| bootstrap(<%= jsComponentName %>App, [ |
There was a problem hiding this comment.
why add them here? the style guide advice (and from Igor) has been to not add providers in the main bootstrap, but instead to put them in the root app component
There was a problem hiding this comment.
I'm okay with that too
There was a problem hiding this comment.
OK. That would be great to move this to the root app component, so we stay in sync
| @@ -1,17 +1,13 @@ | |||
| import {Component} from 'angular2/core'; | |||
| import {RouteConfig, ROUTER_DIRECTIVES, ROUTER_PROVIDERS} from 'angular2/router'; | |||
There was a problem hiding this comment.
This component still has a router-outlet, which means it needs ROUTER_DIRECTIVES I believe.
hansl
force-pushed
the
route-fix
branch
3 times, most recently
from
edc7d57 to
9ce096e
Compare
|
@filipesilva: Please take another look. It passes the tests now. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.