-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@angular/cli): fixing lint documentation #5633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ed21f2e
to
0d87fd3
Compare
LGTM but pinging @Brocco to review it since he did the original work. |
0d87fd3
to
2df4f22
Compare
docs/documentation/e2e.md
Outdated
</p> | ||
<p> | ||
Compile and Serve the app. All serve options are also available. The live-reload option defaults to false, and the default port will be random. | ||
</p> | ||
</details> | ||
|
||
<details> | ||
<summary>no-serve</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'no-' prefix can be used with any Boolean option. A general statement on each command page would probably be more appropriate than singling out the serve option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. @sumitarora can you remove --no-serve
from this list?
docs/documentation/e2e.md
Outdated
</p> | ||
<p> | ||
Compile and Serve the app. All serve options are also available. The live-reload option defaults to false, and the default port will be random. | ||
</p> | ||
</details> | ||
|
||
<details> | ||
<summary>no-serve</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. @sumitarora can you remove --no-serve
from this list?
Seems like the last 2 commits result in not having any code at all...? |
045910f
to
569f094
Compare
@hansl I added code and then removed it fixed the commits now |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes:
#5632
#5713