Skip to content

fix(@angular/cli): fixing lint documentation #5633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2017

Conversation

sumitarora
Copy link
Contributor

@sumitarora sumitarora commented Mar 24, 2017

Fixes:
#5632
#5713

@filipesilva
Copy link
Contributor

LGTM but pinging @Brocco to review it since he did the original work.

@sumitarora
Copy link
Contributor Author

@johnpapa @coryrylan ☝️

</p>
<p>
Compile and Serve the app. All serve options are also available. The live-reload option defaults to false, and the default port will be random.
</p>
</details>

<details>
<summary>no-serve</summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'no-' prefix can be used with any Boolean option. A general statement on each command page would probably be more appropriate than singling out the serve option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. @sumitarora can you remove --no-serve from this list?

</p>
<p>
Compile and Serve the app. All serve options are also available. The live-reload option defaults to false, and the default port will be random.
</p>
</details>

<details>
<summary>no-serve</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. @sumitarora can you remove --no-serve from this list?

@hansl
Copy link
Contributor

hansl commented Mar 29, 2017

Seems like the last 2 commits result in not having any code at all...?

@sumitarora
Copy link
Contributor Author

@hansl I added code and then removed it fixed the commits now

@hansl hansl merged commit 1fa5f2d into angular:master Mar 31, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants