-
Notifications
You must be signed in to change notification settings - Fork 12k
docs: Docker deploy design doc #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
### Overview | ||
|
||
Initialize Docker files and configuration for a default build and run environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, we could have ng docker init
, ng docker log
, ng docker deploy
, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. This was just a straw man, based off of the github-pages:deploy
convention.
One thing I am wrestling with is how to best keep things server agnostic. The Dockerfile in the design defaults to using a Node.js server. Users might like to have more of a choice between server tech or using different container types (ie. Go/Nginx servers, IIS windows server containers). My original thought was to generate a simple Dockerfile that targets the "native" environment of the tool (Node.js). Maybe have an option like But since the artifact from an Angular project is typically just a set of static assets, an alternative idea is to generate a Dockerfile that copies the assets into a generic Data Volume (busybox). The |
I don't know much about Docker, but could you let the user either give you a container that works for him and you just do deployment, or if the user doesn't know what to do he can init a new container using |
Deployment can be as simple as "copy the dist folder over". |
Yes. The current design gathers some necessary info up front in the
Agreed. I reflect about some ways of setting this up for users in this comment. |
@hansl I've cleaned this up a bit more. I made changes based on your feedback (removed prompts), and cut some scope for an initial release (logs, exec). For a default server, I'm going to start with a simple Nginx base image. Users are free to change their Dockerfile and employ different server tech. Working now on a prototype. |
LGTM. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
View rendered markdown