-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(webpack): remove usage of fallbackLoader and loader #4435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just to clarify; this is to fix a warning, correct? There's no need for an emergency release, right? |
That's right @hansl, the apps work fine and the warning only appears once |
Im still getting this issue and I deleted node_modules and redid npm install. Is this not on a release branch or something? I also tried looking for the file to change the lines myself but I dont have a style.ts file |
@HauntedSmores it's been merged into master, it will be available in the next release. |
@beeman Thanks for the response! any idea why I dont have that style.ts file at all? |
@HauntedSmores this file is part of Angular CLI itself, it's not inside your app. If you want to manually get rid of this error, the file should be located in |
This is not only a warning, this error appears 4 times during compilation, and it makes webpack compilation fail... |
any ETA to get this new release ?. Currently, my build is broken .. |
@beeman I know it is, I checked the path from your repo but I don't have styles.ts in the directory you just gave |
I think CLI doesn't install individual ts files .. I can't find it either ... Maybe it is : /usr/lib/node_modules/@angular/cli/models/webpack-configs/styles.js on Ubuntu linux. |
It is also in the project : ./node_modules/@angular/cli/models/webpack-configs/styles.js |
I get this error too when running "ng serve" - although my app still compiles and boots up (see below). So it's more of an annoyance than something critical. But curious, is there a current resolution or do we just need to wait for the next update?
|
When will the next update be released? I also couldn't find |
Also looking for a release promptly with this fix. Thanks in advance! |
For those who cannot find it in Angular CLI, the correct path is
You should see this:
Change the ENJOY THE FIX. 👍 |
@JanStureNielsen this has been fixed in the last release |
The last release v1.0.0-beta.30 was released 10 days ago, and the patch was pushed 7 days ago... doesn't seem to be included in the last release. |
The last release is beta 31 and has the fix. See the readme for the upgrading instructions. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #4434