Skip to content

refactor(@angular-cli): get rid of ast-tools and base-href-webpack #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions packages/@angular-cli/ast-tools/package.json

This file was deleted.

24 changes: 0 additions & 24 deletions packages/@angular-cli/ast-tools/tsconfig.json

This file was deleted.

25 changes: 0 additions & 25 deletions packages/@angular-cli/base-href-webpack/package.json

This file was deleted.

27 changes: 0 additions & 27 deletions packages/@angular-cli/base-href-webpack/tsconfig.json

This file was deleted.

3 changes: 2 additions & 1 deletion packages/@angular/cli/blueprints/component/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import {NodeHost} from '../../lib/ast-tools';

const path = require('path');
const fs = require('fs');
const chalk = require('chalk');
Expand All @@ -7,7 +9,6 @@ const findParentModule = require('../../utilities/find-parent-module').default;
const getFiles = Blueprint.prototype.files;
const stringUtils = require('ember-cli-string-utils');
const astUtils = require('../../utilities/ast-utils');
const NodeHost = require('@angular-cli/ast-tools').NodeHost;

export default Blueprint.extend({
description: '',
Expand Down
3 changes: 2 additions & 1 deletion packages/@angular/cli/blueprints/directive/index.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import {NodeHost} from '../../lib/ast-tools';

const path = require('path');
const fs = require('fs');
const chalk = require('chalk');
const dynamicPathParser = require('../../utilities/dynamic-path-parser');
const stringUtils = require('ember-cli-string-utils');
const astUtils = require('../../utilities/ast-utils');
const findParentModule = require('../../utilities/find-parent-module').default;
const NodeHost = require('@angular-cli/ast-tools').NodeHost;
const Blueprint = require('../../ember-cli/lib/models/blueprint');
const getFiles = Blueprint.prototype.files;

Expand Down
3 changes: 2 additions & 1 deletion packages/@angular/cli/blueprints/pipe/index.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import {NodeHost} from '../../lib/ast-tools';

const path = require('path');
const fs = require('fs');
const chalk = require('chalk');
const dynamicPathParser = require('../../utilities/dynamic-path-parser');
const stringUtils = require('ember-cli-string-utils');
const astUtils = require('../../utilities/ast-utils');
const findParentModule = require('../../utilities/find-parent-module').default;
const NodeHost = require('@angular-cli/ast-tools').NodeHost;
const Blueprint = require('../../ember-cli/lib/models/blueprint');
const getFiles = Blueprint.prototype.files;

Expand Down
2 changes: 1 addition & 1 deletion packages/@angular/cli/blueprints/service/index.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import {NodeHost} from '../../lib/ast-tools';
import { oneLine } from 'common-tags';

const path = require('path');
const fs = require('fs');
const chalk = require('chalk');
const dynamicPathParser = require('../../utilities/dynamic-path-parser');
const Blueprint = require('../../ember-cli/lib/models/blueprint');
const NodeHost = require('@angular-cli/ast-tools').NodeHost;
const stringUtils = require('ember-cli-string-utils');
const astUtils = require('../../utilities/ast-utils');
const getFiles = Blueprint.prototype.files;
Expand Down
2 changes: 1 addition & 1 deletion packages/@angular/cli/models/webpack-configs/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as webpack from 'webpack';
import * as path from 'path';
import { GlobCopyWebpackPlugin } from '../../plugins/glob-copy-webpack-plugin';
import { packageChunkSort } from '../../utilities/package-chunk-sort';
import { BaseHrefWebpackPlugin } from '@angular-cli/base-href-webpack';
import { BaseHrefWebpackPlugin } from '../../lib/base-href-webpack';
import { extraEntryParser, lazyChunksFilter, getOutputHashFormat } from './utils';
import { WebpackConfigOptions } from '../webpack-config';

Expand Down
4 changes: 2 additions & 2 deletions packages/@angular/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,10 @@
},
"homepage": "https://github.com/angular/angular-cli",
"dependencies": {
"@angular-cli/ast-tools": "^1.0.14",
"@angular-cli/base-href-webpack": "^1.0.14",
"@angular/compiler": "^2.3.1",
"@angular/compiler-cli": "^2.3.1",
"@angular/core": "^2.3.1",
"@angular/tsc-wrapped": "^0.5.0",
"@ngtools/json-schema": "^1.0.0",
"@ngtools/webpack": "^1.2.3",
"async": "^2.1.4",
Expand Down Expand Up @@ -74,6 +73,7 @@
"resolve": "^1.1.7",
"rimraf": "^2.5.3",
"rsvp": "^3.0.17",
"rxjs": "^5.0.1",
"sass-loader": "^4.1.1",
"script-loader": "^0.7.0",
"semver": "^5.1.0",
Expand Down
3 changes: 0 additions & 3 deletions packages/@angular/cli/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
],
"baseUrl": "",
"paths": {
"@angular-cli/ast-tools": [ "../../../dist/@angular-cli/ast-tools/src" ],
"@angular-cli/base-href-webpack": [ "../../../dist/@angular-cli/base-href-webpack/src" ],
"@angular-cli/version": [ "../../../dist/@angular-cli/version/src" ],
"@ngtools/json-schema": [ "../../../dist/@ngtools/json-schema/src" ],
"@ngtools/webpack": [ "../../../dist/@ngtools/webpack/src" ]
}
Expand Down
2 changes: 1 addition & 1 deletion packages/@angular/cli/utilities/ast-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ export {
addDeclarationToModule,
addProviderToModule,
addExportToModule
} from '@angular-cli/ast-tools';
} from '../lib/ast-tools';
2 changes: 1 addition & 1 deletion packages/@angular/cli/utilities/change.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ export {
InsertChange,
RemoveChange,
ReplaceChange
} from '@angular-cli/ast-tools';
} from '../lib/ast-tools';
2 changes: 1 addition & 1 deletion packages/@angular/cli/utilities/module-resolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import * as dependentFilesUtils from './get-dependent-files';


import {Change, ReplaceChange} from './change';
import {NodeHost, Host} from '@angular-cli/ast-tools';
import {NodeHost, Host} from '../lib/ast-tools';

/**
* Rewrites import module of dependent files when the file is moved.
Expand Down
2 changes: 1 addition & 1 deletion packages/@angular/cli/utilities/route-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ export {
confirmComponentExport,
resolveComponentPath,
applyChanges
} from '@angular-cli/ast-tools';
} from '../lib/ast-tools';
2 changes: 1 addition & 1 deletion tests/e2e/utils/ast.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {
insertImport as _insertImport,
addImportToModule as _addImportToModule,
NodeHost
} from '@angular-cli/ast-tools';
} from '../../../packages/@angular/cli/lib/ast-tools';


export function insertImport(file: string, symbol: string, module: string) {
Expand Down