Skip to content

fix: use symLinkSync #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2016
Merged

fix: use symLinkSync #410

merged 1 commit into from
Apr 8, 2016

Conversation

cexbrayat
Copy link
Member

Using the latest releases of angular-cli (up to 0.0.30), I've been running into an issue when the build is in a VM/docker container and using a shared file system with the host (EPERM: operation not permitted for BroccoliTypeScriptPlugin).

After some research, it looks like it's not a new problem in the Broccoli/Ember-cli world, and that it is recommended to use fs.symlinkSync instead of fs.linkSync.

See ember-cli/broccoli-caching-writer#2 for example and the related links.

It does appear to solve the problem, so here is a humble PR to (hopefully) fix it.

@filipesilva
Copy link
Contributor

lgtm but I'll defer to @hansl as he's been editing that file recently.

@filipesilva
Copy link
Contributor

And thanks for fixing it @cexbrayat !

@hansl
Copy link
Contributor

hansl commented Apr 8, 2016

Thanks @cexbrayat for the fix! Seems I missed that :)

I'm rerunning the Windows tests. It's the only area where I'm not 100% sure symlink work. If the tests pass I'll merge.

@hansl hansl merged commit 4fe8687 into angular:master Apr 8, 2016
@cexbrayat cexbrayat deleted the fix/symlink branch April 8, 2016 21:13
@cexbrayat cexbrayat restored the fix/symlink branch April 8, 2016 21:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants