Skip to content

fix: use explicit Number() instead of unary plus #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2016
Merged

fix: use explicit Number() instead of unary plus #395

merged 1 commit into from
Apr 6, 2016

Conversation

RoPP
Copy link
Contributor

@RoPP RoPP commented Apr 6, 2016

Probably not important for the experienced js developers but it's more readable for newcomers (at least for me!).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@RoPP
Copy link
Contributor Author

RoPP commented Apr 6, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jkuri
Copy link
Contributor

jkuri commented Apr 6, 2016

Hi @RoPP, thank you for the PR. LGTM.

@filipesilva
Copy link
Contributor

lgtm as well, thank you!

@filipesilva filipesilva merged commit 7bc20ff into angular:master Apr 6, 2016
@RoPP RoPP deleted the explicit-is-better-than-implicit branch April 7, 2016 07:11
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants